refactor: extract service #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we always parse the projects editor version so that we can put it into the env object. But we only use the editor-version inside the add command. So there is no reason to load it for example for the search command. This change extracts the logic for determining a projects editor-version into its own service which is now used by the add command. This way users can now use other commands outside of unity projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always parse the projects editor version so that we can put it into the env object. But we only use the editor-version inside the add command. So there is no reason to load it for example for the search command.
This change extracts the logic for determining a projects editor-version into its own service which is now used by the add command. This way users can now use other commands outside of unity projects.